Merged
Conversation
klkvr
force-pushed
the
klkvr/bump-alloy
branch
from
0d76421 to
19072c7
Compare
klkvr
force-pushed
the
klkvr/bump-alloy
branch
from
9e1e4b9 to
7644d32
Compare
klkvr
requested review from
joshieDo,
mattsse,
rakita and
shekhirin
as code owners
klkvr
requested review from
Rjected,
emhane,
fgimenez,
gakonst,
onbjerg and
rkrasiuk
as code owners
mattsse
approved these changes
Nov 6, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
wow, this simplifies things a lot
Comment on lines
-107
to
-108
| // only include is_system_tx if true: <https://github.com/ethereum-optimism/op-geth/blob/641e996a2dcf1f81bac9416cb6124f86a69f1de7/internal/ethapi/api.go#L1518-L1518> | ||
| is_system_tx: (signed_tx.is_deposit() && signed_tx.is_system_transaction()) |
Collaborator
There was a problem hiding this comment.
ah great, this is now solved directly via the field
Comment on lines
8
to
14
| pub fn from_primitive_storage_proof(proof: StorageProof) -> EIP1186StorageProof { | ||
| EIP1186StorageProof { key: JsonStorageKey(proof.key), value: proof.value, proof: proof.proof } | ||
| EIP1186StorageProof { | ||
| key: JsonStorageKey::Hash(proof.key), | ||
| value: proof.value, | ||
| proof: proof.proof, | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Idea for followup, should we move those alloy types into alloy-eips?
Member
Author
There was a problem hiding this comment.
eip1186 mod might make sense, though this EIP is basically just RPC spec so probably would still be closer to RPC types
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps alloy-core, alloy and op-alloy
Related PRs:
alloy-rs/op-alloy#205
alloy-rs/alloy#1540
alloy-rs/core#796